Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget documentation sweep #1909
Widget documentation sweep #1909
Changes from 87 commits
fb02fde
597b46f
3602dab
ac18b00
cfb21d0
f96eb93
27e1311
318e129
d0dedc0
4a505e8
b071121
766cae2
4258698
61aa558
287ef15
ed2d547
87f2169
74526c1
c619984
c0cc080
8b22875
4271886
11e16b4
43cc67d
3478615
a326169
d4ef173
a4f22d0
5a61459
bba5017
d50fcc7
46bf558
8f9cf74
4971e0e
9c45c7d
75625ef
52adf3f
7ca3357
865a8e5
662c1d8
e21e552
a837cd1
ac35c1d
dbb5263
3192ee7
3658610
6e836de
3f90812
e8d0f7a
65ba559
2e060c0
acb1cc6
6d03829
106c5aa
fa1f699
80fd76f
40b41a1
8917bb6
3850070
fb5a10a
b73cd78
abdcf2f
21e7cfb
22b0b5b
48dd54c
af6d56c
cf34e5e
2fce894
52b69d5
88f771b
ee126a9
30d8943
ef29a77
acaec34
e8537c6
2deb90e
0992b36
f8167ac
ca1abcf
b617d67
3122748
ab963d2
ce016d5
5afbf48
53b0e54
24fa963
aa96b54
847e2cc
768d4ae
348fbe2
b1c6da2
b3fe97e
88fcf4f
5cfa998
d9ab2ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a difference between surrounding
True
with a pair of backticks versus two pairs of backticks? I have seen both and haven't understood the difference yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question; I was asking myself the same thing as I was going through the docstrings and seeing a difference. I tested it and from what I can tell there's zero difference; both have the same effect (my uninformed guess here would be it's mkdocstrings or something supporting a couple of other doc systems' styles).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of moving the variant table from
Placeholder
up to here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this. Yeah, I was debating that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as my understanding goes,
var
is just an "alias" for a quick way to create a reactive attribute with some parameters in pre-defined values.Would it be worth typing
max_lines
asmax_lines: reactive[int | None] = var[Optional[int]](None)
?(This was not a rhetoric question.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What benefit do we get from that? A downside I can see is that it might be confusing to a reader of the code, seeing two "different" types like that.