Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix walk children #1873

Merged
merged 2 commits into from
Feb 24, 2023
Merged

fix walk children #1873

merged 2 commits into from
Feb 24, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Feb 24, 2023 •
edited
Loading

Fixes #1846

The walk_children method was looking at node._nodes rather then node.children which mean that all screens were walked, rather than the active screen.

@willmcgugan willmcgugan marked this pull request as draft February 24, 2023 10:03
@willmcgugan willmcgugan marked this pull request as ready for review February 24, 2023 10:19
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away! 🚀

@willmcgugan willmcgugan merged commit 96370b1 into main Feb 24, 2023
@willmcgugan willmcgugan deleted the screen-children-fix branch February 24, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@darrenburns darrenburns Awaiting requested review from darrenburns

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs related to multi-screen approach
2 participants
@willmcgugan @rodrigogiraoserrao