Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paste and test #1698

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Fix paste and test #1698

merged 3 commits into from
Jan 31, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jan 31, 2023 •
edited
Loading

Fix issue with paste event that prevented the app from handling it.

Fixes #1666

rodrigogiraoserrao
rodrigogiraoserrao approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event.is_forwarded flag is the flag that takes care of making sure the app directs the events to the correct place, let them bubble up once, and then get rid of them?

@willmcgugan
Copy link
Collaborator Author

@rodrigogiraoserrao Exactly.

@willmcgugan willmcgugan merged commit dc1c4da into main Jan 31, 2023
@willmcgugan willmcgugan deleted the fix-paste branch January 31, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@darrenburns darrenburns Awaiting requested review from darrenburns

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review how the Paste event is handled and bubbled
2 participants
@willmcgugan @rodrigogiraoserrao