Scroll sensitivity #1689
Scroll sensitivity #1689
Conversation
src/textual/app.py
Outdated
| @@ -369,6 +369,11 @@ def __init__( | |||
| self.css_path = css_paths | |||
| self._registry: WeakSet[DOMNode] = WeakSet() | |||
|
|
|||
| self.scroll_sensitivity_x: float = 4 | |||
There was a problem hiding this comment.
Scrolling in x dimension is double to make the perceived distance the same in both directions (given cells are typically twice as tall as they are wide).
There was a problem hiding this comment.
Wouldn't that make for a good # comment in the original source?
| if self.scroll_up(animate=False): | ||
| event.stop() | ||
| def _on_mouse_scroll_down(self, event: events.MouseScrollDown) -> None: | ||
| if event.ctrl or event.shift: |
There was a problem hiding this comment.
Do we want to steal both control and shift here? I forget which one is usually used for this kind of behaviour.
If we steal both, users wouldn't be able to do something like "hold shift and use mouse wheel to zoom instead of scroll", would they?
There was a problem hiding this comment.
Ideally it would be shift+mouse wheel only, but the problem is that iTerm doesn't report shift when pressed with the mouse wheel. Kitty does. I added both shift and ctrl so there is at least one way of horizontal scrolling.
There was a problem hiding this comment.
Pease check this out and play with scrolling. I'm concerned that it may work for me, and break others.
Tested on macOS with both a Magic Trackpad and a Logitech M575 trackball. In this version scrolling with the trackpad is obviously faster, but I find it just as comfortable to control; starting and stopping and getting to where I want to be vertically feels about the same (testing with the Textual demo). With the scroll wheel on the M575, while still a bit of a snooze-fest when it comes to scrolling, it's obviously far better than before this change (I had two windows open side-by-side, without and with this change, to compare).
Hopefully this'll be the bedrock for a method of letting people configure it "just so", in which case I see this as really handy and, from my experience, it doesn't impact my current use of Textual in iTerm on macOS.
I've doubled the scroll speed which makes the wheel somewhat usable, and the trackpad remains usable if a little faster.
There is no way to know which is being used, which means we need to find settings that works with both.
Please check this out and play with scrolling. I'm concerned that it may work for me, and break others.