Make default filename for screenshots use ISO8601 datetime format #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davep
reviewed
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
save_screenshotfunction uses a datetime format by default that (a) introduces spaces to the resulting filename and (b) does not match what is specified in the doc-string. This PR will replace those spaces and bring the datetime format closer to the ISO8601 format. (Since colons are a reserved character, the format will not exactly match ISO8601.)Before: (the filename for a screenshot may look like)
demo 20230107 205720 203616.svgAfter: (the filename for a screenshot may look like)
demo_2023-01-07T22_52_31.512393.svgFeedback welcome