Add public access (both get and set) to the label of a TreeNode
#1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's an asymmetry in how the label is handled for a TreeNode. If a str label is passed to the constructor it stays as a str type. On the other hand, if it's set via set_label, it gets processed into a Rich Text type. This commit removes that asymmetry.
This adds public support to reading a TreeNode's label, and also setting it too. See Textualize#1396.
There's going to be a whole bunch of tests relating to the Tree and TreeNode coming, let's make sure this ends up being fairly granular. (side thought: it might be a good time soon to revisit all the tests for Textual and try and wrangle them into some tidy structure)
src/textual/widgets/_tree.py
Outdated
| def label(self, new_label: TextType) -> TextType: | ||
| """TextType: The label for the node.""" | ||
| self.set_label(new_label) | ||
| return self.label |
There was a problem hiding this comment.
By the way, what does it mean for the setter to return the new value?
There was a problem hiding this comment.
Actually, come to think of it, in Python, nothing useful at all. Hangover from elsewhere (languages where assignments are also expressions).
There was a problem hiding this comment.
Yeah, I think C++ need that to chain assignments, like foo = bar = obj.egg
There was a problem hiding this comment.
Ditto Clipper with the likes of Class(y), for those of a particular vintage (if I'm recalling correctly).
Python is expressive, but it ain't that expressive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1396 this adds support for public access to the label of a
TreeNode, via alabelproperty. Both get and set access is provided. In addition to that main change, the constructor ofTreeNodehas been slightly modified so that the incoming label is processed viaTree.process_labelto match the way thatTreeNode.set_labelworks. Without this there was an asymmetry to how astrlabel was set.