Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for visiblity #1327

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix for visiblity #1327

merged 2 commits into from
Dec 7, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Dec 7, 2022

Fixes #1313

Essentially "visibility: hidden" only changed the one widget were it was set. This PR makes the visibility apply to children. It also allows children to change their visibility.

Consider implementing a dialog. A layer can be a container with a center aligned child widget. The container is hidden, but the child is unhidden. So the dialog floats over the content below.

Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem sensible but I am not comfortable enough with the compositor to say the changes are OK.

@davep
Copy link
Contributor

davep commented Dec 7, 2022

Consider implementing a dialog. A layer can be a container with a center aligned child widget. The container is hidden, but the child is unhidden. So the dialog floats over the content below.

I know it's out of the scope of this change, but I suspect this isn't how you'd want to implement a dialog most of the time, right? All sorts of binding issues to be had here as I'm thinking about it. (which brings us back to screens that can be transparent and float over other screens).

@willmcgugan
Copy link
Collaborator Author

Consider implementing a dialog. A layer can be a container with a center aligned child widget. The container is hidden, but the child is unhidden. So the dialog floats over the content below.

I know it's out of the scope of this change, but I suspect this isn't how you'd want to implement a dialog most of the time, right? All sorts of binding issues to be had here as I'm thinking about it. (which brings us back to screens that can be transparent and float over other screens).

Don't see why not. Wouldn't solve the focus issues, but seems like a good way of rendering a floating thing.

@willmcgugan willmcgugan merged commit c68e749 into main Dec 7, 2022
@willmcgugan willmcgugan deleted the visibility-fix branch December 7, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility rule doesn't impact children
3 participants