Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutError when finding nothing in the Command Palette (Python <3.11) #3320

Closed
davep opened this issue Sep 16, 2023 · 3 comments · Fixed by #3321
Closed

TimeoutError when finding nothing in the Command Palette (Python <3.11) #3320

davep opened this issue Sep 16, 2023 · 3 comments · Fixed by #3321
Assignees
@davep
Labels
bug Something isn't working Task

Comments

@davep
Copy link
Contributor

davep commented Sep 16, 2023

To test this, make a fresh installation of Textual, then run:

$ python -m textual

To run up the demo. Press Ctrl+\ to pull up the command palette, then type something that won't be found, such as "hello". Within a moment or so you should get a TimeoutError.

Note that this seems to only be an issue with Pythons less than 3.11.
@davep davep added bug Something isn't working Task labels Sep 16, 2023
@SkwalExe
Copy link

I was able to reproduce the issue on python 3.10

@davep
Copy link
Contributor Author

davep commented Sep 16, 2023

As best as I can tell, this comes down to this commit: eaa7496

@willmcgugan Was there a reason for switching from asyncio.TimeoutError to TimeoutError here? I also gather that there is a change from 3.11 onward that we need to take into account?

@davep davep self-assigned this Sep 16, 2023
davep added a commit to davep/textual that referenced this issue Sep 16, 2023
@davep
Reinstate the import of TimeoutError from asyncio
c822d49 
Fixes Textualize#3320

It looks like eaa7496 smuggled this change
in and caused the command palette to cease to work correctly on any version
of Python before 3.11.

This should make it work on all Pythons from 3.7 onward again.
@davep davep mentioned this issue Sep 16, 2023
Merged
willmcgugan pushed a commit that referenced this issue Sep 16, 2023
@davep
Fix command palette TimeoutError error (#3321)
bebadb0 
* Reinstate the import of TimeoutError from asyncio

Fixes #3320

It looks like eaa7496 smuggled this change
in and caused the command palette to cease to work correctly on any version
of Python before 3.11.

This should make it work on all Pythons from 3.7 onward again.

* Update the CHANGELOG
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
bug Something isn't working Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix command palette TimeoutError error davep/textual
2 participants
@davep @SkwalExe