-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips should be removed on widget unmount and scrolling #3045
Comments
Just to check: there's a typo here @darrenburns? This is trying to say that if you scroll the tooltip remains, or something else? |
It remains, yeah |
Another situation: if a widget is |
And another situation: if a widget is |
#4191 is working well and seems to cover all the bases. We've decided that we should open it up a little and make this based off a signal, which will be published when a layout change happens, and so they the tooltip system can subscribe to it (the idea being someone's third party tooltip system could do the same). Also, in addition to this: tooltips don't go away if a screen is pushed on top of a screen that is currently displaying a tooltip, so we'll look at taking that into account too. |
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
When a tooltip is visible on screen, and the widget it's associated with gets unmounted. The tooltip remains on screen, which looks kind of weird.
Also, if a tooltip is visible, and you scroll such that the widget is no longer on screen, the tooltip remains. When you finally move the cursor, it disappears.
When the parent is unmounted, or when we scroll, I believe the tooltips should be hidden immediately.
The text was updated successfully, but these errors were encountered: