Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown.load should raise an exception if the file is not found #2956

Closed
willmcgugan opened this issue Jul 17, 2023 · 1 comment · Fixed by #2972
Closed

Markdown.load should raise an exception if the file is not found #2956

willmcgugan opened this issue Jul 17, 2023 · 1 comment · Fixed by #2972
Assignees
@davep

Comments

@willmcgugan
Copy link
Collaborator

At the moment it will return False if not found. It should really raise an exception. Maybe just let FileNotFoundError bubble up.
@davep davep self-assigned this Jul 19, 2023
davep added a commit to davep/textual that referenced this issue Jul 19, 2023
@davep
Change Markdown.load so that load errors propagate
3111ce7 
See Textualize#2956.
@davep davep mentioned this issue Jul 19, 2023
Merged
@davep davep linked a pull request Jul 19, 2023 that will close this issue
Change Markdown.load so that load errors propagate #2972
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Markdown.load so that load errors propagate davep/textual
2 participants
@davep @willmcgugan