Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectionList: checked, non-highlighted, non-focused Xs are shown in white rather than green #2768

Closed
davep opened this issue Jun 12, 2023 · 3 comments · Fixed by #2842
Closed
Labels
bug Something isn't working Task

Comments

@davep
Copy link
Contributor

davep commented Jun 12, 2023

There looks to be a missing style case in the SelectionList if an item in the list is checked, isn't highlighted, and the SelectionList doesn't have focus; when that happens the X falls to being white, where it should retain its green colour. Here's a SelectionList that is focused:

Screenshot 2023-06-12 at 11 24 20

and the same list without focus:

Screenshot 2023-06-12 at 11 24 55

Most likely a missing rule in the DEFAULT_CSS or missing the right combination in render_line.

@davep davep added bug Something isn't working Task labels Jun 12, 2023
@darrenburns
Copy link
Member

Style sandwich strikes again

@davep
Copy link
Contributor Author

davep commented Jun 12, 2023

At this rate style sandwich might need its own issue label. 🤔

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
2 participants