Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing a screen should send Leave message #2606

Closed
willmcgugan opened this issue May 18, 2023 · 4 comments · Fixed by #2621
Closed

Pushing a screen should send Leave message #2606

willmcgugan opened this issue May 18, 2023 · 4 comments · Fixed by #2621
Assignees

Comments

@willmcgugan
Copy link
Collaborator

If you have an action that opens a screen, it leaves the footer stuck in the highlight state.

I think we need to call _set_mouse_over(None) on the current screen when pushing another screen.

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 22, 2023
@rodrigogiraoserrao
Copy link
Contributor

I can't repro this.

@willmcgugan
Copy link
Collaborator Author

Do you have Trogon? Run one of the examples and click the footer. When the modal returns the footer is stuck in a highlight state.

I suspect you could reproduce this will any app with a footer that launches a modal.

@rodrigogiraoserrao
Copy link
Contributor

I suspect you could reproduce this will any app with a footer that launches a modal.

That's it. The original issue wasn't explicit and I was using regular screens. I can repro it when pushing a modal.

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants