Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable - When cursor_coordinate updates, we should scroll_cursor_visible #2459

Closed
rodrigogiraoserrao opened this issue May 2, 2023 · 1 comment · Fixed by #2464
Closed

DataTable - When cursor_coordinate updates, we should scroll_cursor_visible #2459

rodrigogiraoserrao opened this issue May 2, 2023 · 1 comment · Fixed by #2464
Assignees
@rodrigogiraoserrao
Labels
enhancement New feature or request Task

Comments

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented May 2, 2023 •
edited
Loading

When the cursor moves out of the screen, we should scroll the cursor into visibility.

It seems like there is already code to do this, but because of #2458 the scrolling doesn't work.
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 2, 2023
@rodrigogiraoserrao rodrigogiraoserrao added enhancement New feature or request Task labels May 2, 2023
rodrigogiraoserrao added a commit that referenced this issue May 3, 2023
@rodrigogiraoserrao
Scroll cursor into view.
56f9283 
Related issues: #2459.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue May 3, 2023
Merged
@rodrigogiraoserrao rodrigogiraoserrao linked a pull request May 3, 2023 that will close this issue
Scroll cursor into view. #2464
Merged
rodrigogiraoserrao added a commit that referenced this issue May 3, 2023
@rodrigogiraoserrao
Scroll cursor into view. (#2464)
3728555 
* Scroll cursor into view.

Related issues: #2459.

* Add regression test.

* Update changelog.
@github-actions
Copy link

github-actions bot commented May 3, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

@href href mentioned this issue May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scroll cursor into view. Textualize/textual
1 participant
@rodrigogiraoserrao