Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_one should raise an exception #1096

Closed
willmcgugan opened this issue Nov 2, 2022 · 2 comments
Closed

query_one should raise an exception #1096

willmcgugan opened this issue Nov 2, 2022 · 2 comments

Comments

@willmcgugan
Copy link
Collaborator

The query_one method should raise an exception if there isn't exactly one result from the query.
davep added a commit to davep/textual that referenced this issue Nov 2, 2022
@davep
Add a reminder to the mount tests about query_one
f29015f 
See Textualize#1096
@davep
Copy link
Contributor

davep commented Nov 2, 2022

Once done, a TODO item in test_widget_mounting.py can be uncommented and put into play (if/when #1095 is merged).

davep added a commit to davep/textual that referenced this issue Nov 3, 2022
@davep
Change query_one so that it raises an error on multiple hits
c1cfdff 
As part of this, add a only_one method to DOMQuery.

Addresses Textualize#1096.
@davep davep mentioned this issue Nov 3, 2022
Merged
@davep davep closed this as completed Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Did we solve your problem?

Glad we could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davep @willmcgugan