Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Progress printing an empty line after finishing in jupyter #2867

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

cceyda
Copy link
Contributor

@cceyda cceyda commented Mar 8, 2023

Type of changes

I accidently closed the prev PR #2616 during main sync, reopened here

  • Bug fix

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.(Not sure how to write a test for this)
  • I accept that @willmcgugan may be pedantic in the code review.

Description

More of a cosmetic fix than a bugfix, but the extra lines were just not fun to look at.
In notebooks 2 extra empty lines were printed after the progress bar finished (where console.is_jupyter) as seen below:
image

It is even more visible in vs-code:
image

There is still one empty line being printed at the end, but I suspect that maybe a well known ipywidgets problem. ref: jupyter-widgets/ipywidgets#2880

tested it manually 👀 in vs-code(latest: 1.72.2), jupyterlab, and google colab(it was never printing empty lines)

Copy link

@alexisthual alexisthual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
As previously stated, I am very interested in seeing this merged as I have a storm of newlines in my vscode interactive windows 😊
It'd be nice to see where the remaining new line comes from as well.

@cceyda
Copy link
Contributor Author

cceyda commented Mar 8, 2023

the remaining new line is hopefully fixed once vscode supports ipywidgets 8 🤞 edit: It's not 😞

@alexisthual
Copy link

alexisthual commented Mar 8, 2023

> the remaining new line is hopefully fixed once vscode supports ipywidgets 8 crossed_fingers

It seems that this should be the case now: microsoft/vscode-jupyter#8552
But it's likely that these changes have not been released yet.

@cceyda cceyda changed the title Progress prints an empty line after finishing in jupyter Fix: Progress printing an empty line after finishing in jupyter Mar 9, 2023
@willmcgugan willmcgugan merged commit 326f8ce into Textualize:master Jul 1, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants