Improve performance of cell_length #2061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
5-6% performance improvement on
python -m rich
Removes the use of the regex for detecting codepoints in ranges we know to be single characters. It was consistently slower regardless of where cache lookups happened.
I've also removed the bounds on key length on the cell_len cache, which resulted in another immediately noticeable improvement.
master
:this branch:
Combining this change and the other PR which adjusted regex and caching - cumulative time spend inside
cell_len
duringpython -m rich
has dropped from 0.02047 to 0.0056. See image below (top is old, bottom is new).