-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IcebergDocument as one implementation of VirtualDocument #3147
Open
bobbai00
wants to merge
67
commits into
master
Choose a base branch
from
jiadong-add-file-result-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...orkflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ItemizedFileDocument.scala
Outdated
Show resolved
Hide resolved
...orkflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ItemizedFileDocument.scala
Outdated
Show resolved
Hide resolved
bobbai00
force-pushed
the
jiadong-add-file-result-storage
branch
2 times, most recently
from
December 14, 2024 00:14
6522779
to
a83d779
Compare
bobbai00
force-pushed
the
jiadong-add-file-result-storage
branch
2 times, most recently
from
December 21, 2024 02:56
1edb551
to
cef347b
Compare
bobbai00
changed the title
Add PartitionDocument and ItemizedFileDocument
Add IcebergDocument as one implementation of VirtualDocument that can be used to store operator results
Dec 22, 2024
bobbai00
changed the title
Add IcebergDocument as one implementation of VirtualDocument that can be used to store operator results
Add IcebergDocument as one implementation of VirtualDocument
Dec 22, 2024
# Conflicts: # core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/OpResultStorage.scala
… into jiadong-add-file-result-storage
# Conflicts: # core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/SpecialPhysicalOpFactory.scala # core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/sink/ProgressiveSinkOpExec.scala
This reverts commit a2e53b5.
shengquan-ni
reviewed
Jan 3, 2025
@transient lazy val catalog: Catalog = IcebergCatalogInstance.getInstance() | ||
|
||
// During construction, create or override the table | ||
synchronized { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this synchronized
is unnecessary as it only locks this
instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Apache Iceberg for Result Storage
How to Enable Iceberg Result Storage
storage-config.yaml
:result-storage-mode
toiceberg
.Major Changes
IcebergDocument
: A thread-safeVirtualDocument
implementation for storing and reading results in Iceberg tables.IcebergTableWriter
: Append-only writer for Iceberg tables with configurable buffer size.file:/
) viaHadoopCatalog
andHadoopFileIO
. This ensures Iceberg operates without relying on external storage services.ProgressiveSinkOpExec
with a new parameterworkerId
is added. Each writer of the result storage will take thisworkerId
as one new parameter.Dependencies
HadoopCatalog
andHadoopFileIO
. These libraries are used for placeholder configuration but do not enforce runtime dependency on HDFS.Overview of Iceberg Components
IcebergDocument
IcebergTableWriter
workerIndex_fileIndex
format).Data Storage via Iceberg Tables
storage key
.IcebergDocument.get
to fetch data via an iterator.Data Reading Using File Metadata
getUsingFileSequenceOrder
, which:FileScanTask
) by sequence numbers.from
,until
) and incremental reads.Hadoop Usage Without HDFS
HadoopCatalog
uses an empty Hadoop configuration, defaulting to the local file system (file:/
).