Skip to content

Commit

Permalink
Fix spotbugs minor issues
Browse files Browse the repository at this point in the history
  • Loading branch information
huzaifaAhmedTestlio committed Oct 26, 2022
1 parent c2a4975 commit 7ce6cb4
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public class AutomatedRunResultsDTO {
private Result results;

@Data
public class Result {
public static class Result {
private String result;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class BrowsersDTO {
private List<BrowserData> data;

@Data
public class BrowserData {
public static class BrowserData {
private String href;
private String id;
private String browserName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class DevicesDTO {
private List<DeviceData> data;

@Data
public class DeviceData {
public static class DeviceData {
private String href;
private String id;
private String model;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class RunConfigurationDTO {
private List<RunConfigurationData> data;

@Data
public class RunConfigurationData {
public static class RunConfigurationData {
private String href;
private String guid;
private String runHref;
Expand All @@ -23,19 +23,19 @@ public class RunConfigurationData {
private ExecutionConfiguration executionConfiguration;

@Data
public class Configuration {
public static class Configuration {
private String networkProfileName;
private Radios radios;
@Data
public class Radios {
public static class Radios {
private boolean wifi;
private boolean bluetooth;
private boolean gps;
private boolean nfc;
}
}
@Data
public class ExecutionConfiguration {
public static class ExecutionConfiguration {
private boolean videoCapture;
private int jobTimeoutMinutes;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/testlio/plugins/jenkins/dto/RunDTO.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class RunDTO {
private Href configuration;

@Data
public class Href {
public static class Href {
private String href;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class UploadDTO {
private Href put;
private Href get;
@Data
public class Href {
public static class Href {
private URL href;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static FileDTO downloadFileFromURL(String URL) {
return ret;
});

if(file.length() > FILE_MAX_SIZE) {
if(file!=null && file.length() > FILE_MAX_SIZE) {
throw new IllegalArgumentException("Uploading "+fileDTO.getFileName()+" failed: max. file size "+FILE_MAX_SIZE/ONE_GB_IN_BYTES+"GB");
}
fileDTO.setFile(file);
Expand Down

0 comments on commit 7ce6cb4

Please sign in to comment.