-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Convert Classic Assert to Constraint Model #1065
Merged
mergify
merged 19 commits into
TestableIO:main
from
vbreuss:topic/prepare-update-to-nunit-v4
Dec 7, 2023
Merged
refactor: Convert Classic Assert to Constraint Model #1065
mergify
merged 19 commits into
TestableIO:main
from
vbreuss:topic/prepare-update-to-nunit-v4
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, Is.Not.EqualTo(expected)), instead of the classic model, ClassicAssert.AreNotEqual(expected, actual))
…)) instead of Assert.AreEqual(expected, actual))
This pull request is a prerequisite for #1058. |
fgreinacher
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I assume you automated this, so I did not look into each and every change 😄)
This is addressed in release v20.0.15. |
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions
Jan 22, 2024
…20.0.15 (#451) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | `20.0.4` -> `20.0.15` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions (TestableIO.System.IO.Abstractions)</summary> ### [`v20.0.15`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.15) #### What's Changed - chore(deps): update dependency benchmarkdotnet to v0.13.11 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1066](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1066) - refactor: Convert Classic Assert to Constraint Model by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1065](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1065) - chore(deps): update actions/upload-artifact action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1068](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1068) - chore(deps): update actions/download-artifact action to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1067](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1067) - chore(deps): update dependency saucecontrol.inheritdoc to v2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1069](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1069) - chore(deps): update apexskier/github-release-commenter action to v1.3.6 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1071](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1071) - chore(deps): update dependency benchmarkdotnet to v0.13.12 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1075](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1075) - chore(deps): update dependency nunit to v4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1058](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1058) - chore(deps): update dependency dotnet-sdk to v8.0.101 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1077](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1077) - refactor: remove workaround for Snapshooter/NUnit 4/.NET 4.6.2 compat… by [@​fgreinacher](https://togithub.com/fgreinacher) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1076](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1076) - fix: use correct path for wrapped `FileInfo` and `DirectoryInfo` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1079](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1079) **Full Changelog**: TestableIO/System.IO.Abstractions@v20.0.4...v20.0.15 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert NUnit asserts to the constraint model, to simplify the migration to NUnit v4.