refactor: update supported frameworks #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fgreinacher
suggested changes
Dec 4, 2023
There was a problem hiding this comment.
Very nice, thanks @vbreuss.
Just two minor things I noticed
src/System.IO.Abstractions.TestingHelpers/System.IO.Abstractions.TestingHelpers.csproj
Outdated
Show resolved
Hide resolved
vbreuss
force-pushed
the
topic/update-framework-to-462
branch
from
7c04982 to
261188d
Compare
The default GitHub token does not trigger the release workflow
|
I bumped the version to 20.0 and added the breaking change trailer to the description. Furthermore I tried to fix the release commenter workflow by adding a dedicated token, as suggested in see https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow. |
fgreinacher
approved these changes
Dec 5, 2023
|
This is addressed in release v20.0.4. |
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions
Dec 6, 2023
…20.0.4 (#433) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | `20.0.1` -> `20.0.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions (TestableIO.System.IO.Abstractions)</summary> ### [`v20.0.4`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.4) ##### What's Changed - refactor: update supported frameworks by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1060](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1060) - fix(ci): make push step idempotent by [@​fgreinacher](https://togithub.com/fgreinacher) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1062](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1062) - fix: combine ci and release workflows by [@​fgreinacher](https://togithub.com/fgreinacher) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1063](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1063) - fix: use correct release commenter version by [@​fgreinacher](https://togithub.com/fgreinacher) in [https://github.com/TestableIO/System.IO.Abstractions/pull/1064](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1064) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.91...v20.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update frameworks in preparation to support nunit v4:
Related to #1058
BREAKING CHANGE: .NET Framework 4.6.1 and .NET 5 targets are not available anymore because they are out of support.