Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct paramName in Path.GetRelativePath #1035

Merged

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Aug 25, 2023

When calling Path.GetRelativePath with an incorrect relativeTo parameter (with whitespace), the ParamName of the exception was incorrectly set to path instead of relativeTo.

Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit e6725f4 into TestableIO:main Aug 29, 2023
8 checks passed
mergify bot referenced this pull request in Testably/Testably.Abstractions Aug 29, 2023
…19.2.69 (#392)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.67` -> `19.2.69` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v19.2.69`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.69)

#### What's Changed

- chore(deps): update dependency microsoft.net.test.sdk to v17.7.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1036](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1036)
- fix: use correct paramName in Path.GetRelativePath by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1035](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1035)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.67...v19.2.69

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link

This is addressed in release v19.2.69.

@github-actions github-actions bot added the state: released Issues that are released label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants