Bugfix: Allow support for screen types with extremely long full type names #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a screen repository
|
I'm having difficulty reproducing these failures on my dev box, will try and re-trigger the test run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the screen identifier is later used to build a filename, extremely long type names (such as those from generic types) end up exceeding the 260 char limit on windows and tend to crash a test when disposing a ScreenRepository.
The test is a little ugly (relies on knowledge of the WindowItemsMap internals) as in the current implementation, it's essentially an integration issue between the ID generated by the ScreenRepository and the filename generated in WindowItemsMap.
A couple of approaches that could allow for this issue to be managed at a unit test level;