-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple cookies and tracking ID refactoring #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byewokko
force-pushed
the
refactoring/multiple-cookies-and-tracking
branch
from
April 19, 2023 12:04
2237a20
to
a690a3b
Compare
… needs to be provided instead.
…being incapable of transferring multiple set-cookie headers)
# Conflicts: # CHANGELOG.md
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
cookie_entry_uri
configured.openid
orcookie
in scope but not both.cookie
in scope redirect to cookie entry URI (which must be configured) and pass the original redirect URI in the query. The cookie entry point then redirects to the original redirect URI.Cookies
SeaCatSCI_<CLIENT_ID_HASH>
, for exampleSeaCatSCI_KKJGBAVXYM2P2UQW
.Cookie introspection setup
client_id
.redirect_uri_validation_method
toprefix_match
and add your app's base URL toredirect_uris
.cookie_entry_uri
, the endpoint where your app's cookie entrypoint will be available (after you set it up in Nginx). It needs to be located on the same hostname as your app's web interface. In this example, we set it tohttps://app.example.test/my_app_bouncer
.<CLIENT_ID>
with your actual client ID.<CLIENT_ID>
with your actual client ID.<CLIENT_ID>
with your actual client ID.Setting custom HTTP headers using a webhook
cookie_webhook_uri
attribute configured to a valid URL.Setting custom cookies
The webhook can be used to setting custom cookies if Nginx is configured accordingly. The webhook must provide the cookie name and value and optionally other parameters. Seacat Auth will propagate that data in the auth request response header. You can then use the
auth_request_set
directive to extract the header value from the response and theadd_header
to create a new Set-Cookie header with that value.Example webhook payload:
Example nginx location config
Client config
New client attributes have been added:
cookie_entry_uri
- cookie entrypoint uri, necessary for cookie requestscookie_webhook_uri
- location where the cookie entrypoint sends webhook PUT requestsanonymous_cid
- credentials ID to use for anonymous sessions, necessary for anonymous access