Refactor/New TeskaLabs Logo Favicon #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pe5h4
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
@petrKavulok Please prior merging, take a look to the comment I wrote and consider it within your decision of merging/updating the xml file
| @@ -3,6 +3,7 @@ | |||
| <msapplication> | |||
| <tile> | |||
| <square70x70logo src="media/favicon/ms-icon-70x70.png"/> | |||
| <square144x144logo src="media/favicon/ms-icon-144x144.png"/> | |||
There was a problem hiding this comment.
@petrKavulok Why did you add a browser config in demo app with absolute path with the slash at the beginning of the path https://github.com/TeskaLabs/asab-webui/blob/798db86905254f01f9ddcf88af8030f0689e474b/demo/public/media/favicon/browserconfig.xml#L5, but here you dont?
There was a problem hiding this comment.
honestly, I played along with the rest of config. I'm not sure how to test this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR
(please don't mind custom title)