Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Information card styling #41

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Conversation

aringocode
Copy link
Collaborator

@aringocode aringocode commented Jun 19, 2023

Changes

  1. card will not resize when an error occurs in an input
  2. disable Save button if hint about wrong input is present
  3. error hint message be cleaned when user click on Cancel button
validationPhoneandEmail.mp4

@aringocode aringocode self-assigned this Jun 19, 2023
@aringocode aringocode requested a review from Pe5h4 June 26, 2023 12:20
Copy link
Collaborator

@Pe5h4 Pe5h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aringocode It looks very good, please verify with Robin on required fields coming from the SeaCat Auth service. But from the code perspective, I think it should be fine. Just doublechecking :)

@aringocode
Copy link
Collaborator Author

@Pe5h4 I checked with Robin. It's still the same.

@aringocode aringocode marked this pull request as ready for review June 27, 2023 09:47
@aringocode aringocode merged commit d1f1eb5 into main Jun 27, 2023
@aringocode aringocode deleted the bugfix/fix-credentials-email-card branch June 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants