-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in a Reverse Function #197
Conversation
To complement the current set of functions I've added in a reverse sequence function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW -is there any way I can PR to the vs util?
On May 18, 2022, at 17:49, Thomas Rich ***@***.***> wrote:
@tnrich approved this pull request.
Excellent thanks @mkapl<https://github.com/mkapl>
Just out of curiosity, do you have a use case for this function?
…-Thomas
—
Reply to this email directly, view it on GitHub<#197 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEZAKRQHVGK4HGICMKFS2OLVKWFY7ANCNFSM5WKHMJVQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@mkapl ya you should be able to once this gets published by making a PR against the vs code extension |
@mkapl ok this is landing in [email protected] |
Reversing a sequence is often useful when setting up workflows that have many ssDNA components. The DNA construct doesn't actually have a complement strand but it's helpful to quickly visualize if it will complement to another sequence by reversing and aligning by hand. Additionally – it's helpful when doing some hand aligning if a sequencing alignment has failed and you want to check what is going on by eye. |
Sorry to bother you – I see that the command is now in VS code but it does not seem to be functioning and can't figure out a fix myself |
@mkapl whoops must've messed something up. I'll look into a fix for this |
@mkapl looks like the updated code I used for the reverse function got compiled "incorrectly" this code, which works correctly: return [...s].reverse().join(""); got compiled into return [].concat(s).reverse().join(""); which does not work correctly. I'm reverting to use the slightly more verbose but simpler method you used to reverse the text originally. Should land in v0.0.12 which I just published so should be available in a few minutes |
Yeah - I often hand align individual sequences if a sequencing run looks bad and it’s really handy to be able to quickly reverse the string in addition to RC-ing and complementing.
It’s also helpful for when I build some workflows that have some ssDNA as those are sometimes useful to work with the reverse to see how it aligns with a certain sequence.
Best, Matias
On May 18, 2022, at 17:49, Thomas Rich ***@***.***> wrote:
@tnrich approved this pull request.
Excellent thanks @mkapl<https://github.com/mkapl>
Just out of curiosity, do you have a use case for this function?
…-Thomas
—
Reply to this email directly, view it on GitHub<#197 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEZAKRQHVGK4HGICMKFS2OLVKWFY7ANCNFSM5WKHMJVQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
To complement the current set of functions I've added in a reverse sequence function