Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in a Reverse Function #197

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

mkapl
Copy link
Contributor

@mkapl mkapl commented May 19, 2022

To complement the current set of functions I've added in a reverse sequence function

To complement the current set of functions I've added in a reverse sequence function
Copy link
Collaborator

@tnrich tnrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thanks @mkapl

Just out of curiosity, do you have a use case for this function?

-Thomas

@mkapl
Copy link
Contributor Author

mkapl commented May 19, 2022 via email

@tnrich
Copy link
Collaborator

tnrich commented May 19, 2022

@mkapl ya you should be able to once this gets published by making a PR against the vs code extension

@tnrich tnrich merged commit c0d8de1 into TeselaGen:master May 19, 2022
@tnrich
Copy link
Collaborator

tnrich commented May 19, 2022

@mkapl ok this is landing in [email protected]

@mkapl
Copy link
Contributor Author

mkapl commented May 19, 2022

Excellent thanks @mkapl

Just out of curiosity, do you have a use case for this function?

-Thomas

Reversing a sequence is often useful when setting up workflows that have many ssDNA components. The DNA construct doesn't actually have a complement strand but it's helpful to quickly visualize if it will complement to another sequence by reversing and aligning by hand.

Additionally – it's helpful when doing some hand aligning if a sequencing alignment has failed and you want to check what is going on by eye.

@mkapl mkapl deleted the reverseSequence branch June 15, 2022 20:30
@mkapl
Copy link
Contributor Author

mkapl commented Jun 15, 2022

Sorry to bother you – I see that the command is now in VS code but it does not seem to be functioning and can't figure out a fix myself

@tnrich
Copy link
Collaborator

tnrich commented Jun 15, 2022

@mkapl whoops must've messed something up. I'll look into a fix for this

tnrich added a commit to TeselaGen/vscode-bio-utils that referenced this pull request Jun 15, 2022
@tnrich
Copy link
Collaborator

tnrich commented Jun 15, 2022

@mkapl looks like the updated code I used for the reverse function got compiled "incorrectly"

this code, which works correctly:

return [...s].reverse().join("");

got compiled into

return [].concat(s).reverse().join("");

which does not work correctly.

I'm reverting to use the slightly more verbose but simpler method you used to reverse the text originally.

Should land in v0.0.12 which I just published so should be available in a few minutes

@mkapl
Copy link
Contributor Author

mkapl commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants