Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows OVE-Electron does not load sequence on start #40

Open
jdmccauley opened this issue Jul 30, 2022 · 23 comments
Open

Windows OVE-Electron does not load sequence on start #40

jdmccauley opened this issue Jul 30, 2022 · 23 comments

Comments

@jdmccauley
Copy link

Hey, @tnrich ,

I use OVE-Electron on both Windows and Mac. On Mac, I appreciate that trying to open a sequence file type (ex: .gb) that I chose OVE-Electron to be my default viewer for, OVE-Electron starts in a new window with the sequence loaded. This does not occur on Windows however. On Windows, if I try to open a sequence file with OVE-Electron set as my default viewer, OVE-Electron just starts with no sequence loaded. I can import my sequence file just fine, but it's more effort than just 'double clicking' my sequence file and OVE-Electron loading it like it does on Mac.

For reference:
Version = 1.3.0
Install source: Windows Store

Best,
Josh

@tnrich
Copy link
Collaborator

tnrich commented Aug 3, 2022

@jdmccauley would you mind opening the devtools on your windows machine after trying to open a sequence and see if you're getting any errors or messages logged out to the console?

Should be under View > Toggle Developer Tools I think..?

Thanks!

@jdmccauley
Copy link
Author

@tnrich

There's no errors that seem relevant to me...

I attached a video showing this behavior. On Mac, double clicking the gb file opens it in OVE Electron on start, whereas on Windows 10 I have to 'Import Sequence' no matter what.

ove_win10_no_open.mp4

@tnrich
Copy link
Collaborator

tnrich commented Aug 8, 2022

@jdmccauley would you mind checking if the latest version 1.4.1 fixes this issue for you? Thanks!

@jdmccauley
Copy link
Author

@tnrich
Just checked, unfortunately it does not.

@0xpsi
Copy link

0xpsi commented Oct 5, 2022

I want to mention that I use ove on linux and have the same issue, would love to be able to open .gb files directly

@tnrich
Copy link
Collaborator

tnrich commented Oct 5, 2022

@0xpsi @jdmccauley darn I thought I'd fixed this.. I'll look into this issue when I get a spare moment..

@tnrich
Copy link
Collaborator

tnrich commented Oct 7, 2022

@0xpsi want to try out this release and let me know if it works for you? - https://github.com/TeselaGen/ove-electron/releases/tag/v1.4.3

@jdmccauley I'm working on releasing the windows version now

@jdmccauley
Copy link
Author

jdmccauley commented Oct 7, 2022 via email

@0xpsi
Copy link

0xpsi commented Oct 7, 2022

@0xpsi want to try out this release and let me know if it works for you? - https://github.com/TeselaGen/ove-electron/releases/tag/v1.4.3

@jdmccauley I'm working on releasing the windows version now

Still unable to get it to work, although I may be doing something wrong. After downloading the .AppImage and making it executable, all I did was create a desktop shortcut in /usr/share/applications but not sure how to "install" it any other way. If I right click a .gb file and "open with" it does not pop up as an option. Is there a particular way to "install" this? I'm on ubuntu 22

@tnrich
Copy link
Collaborator

tnrich commented Oct 11, 2022

@0xpsi what happens when you double click the desktop shortcut you made? Does it launch the tool correctly? I am not familiar with how Linux does things. It seems like it not popping up as an option is perhaps not an issue with ove-electron?

I would expect that ove-electron would at least be an option for opening .gb files from a right click menu but that it would fail at the moment of trying to open it.

@0xpsi
Copy link

0xpsi commented Oct 11, 2022

@tnrich double clicking on the .Appimage file works fine, as well as the desktop shortcut I manually made. Right clicking on .gb files does not show OVE as an option. I believe it was showing as an option when I had it installed as a snap package, but was still only opening a blank file and not the .gb file.

@tnrich
Copy link
Collaborator

tnrich commented Oct 11, 2022

Ok, made a new release that hopefully simplifies the installation process. Basically I pulled the app from the various app stores and am no longer doing any sort of code signing or notarization (since those processes took soooo long to complete it made it difficult to iterate and fix bugs).

The installation instructions and downloads for the latest version (mac/win/linux) can be found here: https://github.com/TeselaGen/ove-electron/releases/tag/v1.5.0

Please let me know if it solves the issues you were seeing @0xpsi and @jdmccauley

Also @0xpsi the linux version icon is messed up right now but that should be fixable in a later release.

@0xpsi
Copy link

0xpsi commented Oct 11, 2022

@tnrich there is arm architecture available but maybe you forgot to include the amd64 also? thanks

@tnrich
Copy link
Collaborator

tnrich commented Oct 11, 2022

@0xpsi whoops didn't even realize that was an option for linux. Makes sense. I'll try to cut a new release with both architectures supported.

@tnrich
Copy link
Collaborator

tnrich commented Oct 11, 2022

@0xpsi ok I updated the release again, please try one more time here https://github.com/TeselaGen/ove-electron/releases/tag/v1.5.0

@0xpsi
Copy link

0xpsi commented Oct 11, 2022

@tnrich great, after installing the amd64 version I am able to open .gb files directly now! I am able to see the icon also.

However one issue now, (unrelated) but it appears it is not saving settings between states now (dark/light theme as well as custom enzyme groups)

@tnrich
Copy link
Collaborator

tnrich commented Oct 12, 2022

However one issue now, (unrelated) but it appears it is not saving settings between states now (dark/light theme as well as custom enzyme groups)

@0xpsi what do you mean by saving settings between states exactly? Between closing and reopening the app?

It seems to be persisting theme and custom enzyme groups for me on Ubuntu running on an ARM architecture. Please open a new issue if you continue to have issues. Thanks! Once @jdmccauley responds we can close this one.

@0xpsi
Copy link

0xpsi commented Oct 12, 2022

@tnrich IDK what happened but seems to be gone now. It's working great for me now on Ubuntu 22, amd64, thanks!

@jdmccauley
Copy link
Author

@tnrich will do soon, sorry I am working from home with my mac. I'll test it when I get to the office where my windows machine lives!

@jdmccauley
Copy link
Author

@tnrich The windows install fails because it cannot find the installed .exe after setup. This fails both non-admin and admin setup runs.
image

@tnrich
Copy link
Collaborator

tnrich commented Oct 18, 2022

Hmm @jdmccauley that is interesting. What version of windows are you on? And how are you installing? Could you provide a few more screenshots of your install process and what happens?

I was able to download the .exe file on Windows 11 and open it and install it and it seemed to work for me. I'll ask a coworker with a windows machine to try as well.

@jdmccauley
Copy link
Author

Here's my system info:

Edition Windows 10 Pro
Version 21H2
Installed on ‎4/‎16/‎2021
OS build 19044.1889
Experience Windows Feature Experience Pack 120.2212.4180.0

Sorry I'm trying to hold out against Windows 11 as long as I can...

More pics:
image
image

It gets to the end of the progress bar really fast.
Then this:
image

Calling 'Fix it':
image

@Norde
Copy link

Norde commented May 11, 2023

Hi There,

Same problem than @jdmccauley regarding the windows installer. I opened a dedicated issue #53.

Regarding the initial topic, ie: that ove does not open .bg file on start (following a double click on .gb file or a right click "open with ove"):

Here is the output in the Dev console following this failure with ove 1.4.2 from MS store (the 1.5.5 cannot be installed on windows as mentioned above):

use-local-storage-state - Error getting stored value, using defaultValue instead: SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at parseJSON (storage.js:63:1)
at Object.get (storage.js:24:1)
at useLocalStorageState.js:139:50
at Object.useMemo (react-dom.production.min.js:172:113)
at exports.useMemo (react.production.min.js:23:102)
at useClientLocalStorageState (useLocalStorageState.js:138:19)
at useLocalStorageState (useLocalStorageState.js:59:1)
at useMeltingTemp (useMeltingTemp.js:4:10)
at index.js:82:31 null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants