Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default formats #7262

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve default formats #7262

wants to merge 3 commits into from

Conversation

mwu2018
Copy link
Contributor

@mwu2018 mwu2018 commented Aug 28, 2024

What this PR does

Fixes https://github.com/TerriaJS/nsw-digital-twin/issues/674

How to test

before
after

After expanding the group, search keyword "instrument" in the catalog. Then go to

  • Digital Earth Australia Hotspots, testing item with type WMS and URL ending with wms.
  • Environmental Planning Instrument - Acid Sulfate Soils, testing item with type Map Service and URL ending with MapServer?f=pjson.
  • Environmental Planning Instrument - Acid Sulfate Soils/Protection, testing item with type Map Service and URL ending with MapServer/1?f=pjson.
  • Transitional - Excluded Land, testing item with type ImageServer and URL ending with ImageServer.

All of the above tests will fail in before.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@mwu2018 mwu2018 marked this pull request as ready for review August 28, 2024 01:20
@ljowen ljowen self-assigned this Aug 28, 2024
definition: {
type: "wms"
type: "wms-group"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this change impact singular WMS layers matching the regex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will become one member group.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants