Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terriajs-cesium 1.15.5. #1219

Merged
merged 4 commits into from
Jan 14, 2016
Merged

Use terriajs-cesium 1.15.5. #1219

merged 4 commits into from
Jan 14, 2016

Conversation

kring
Copy link
Member

@kring kring commented Jan 7, 2016

No description provided.

@keattang
Copy link
Contributor

@kring what's the timeline on using cesium 1.17?

@kring
Copy link
Member Author

kring commented Jan 11, 2016

We haven't been in a hurry to due CesiumGS/cesium#3386. If you have a pressing need we could potentially cherry pick the fix, though.

@keattang
Copy link
Contributor

Not particularly pressing, just looking forward to the performance benefits :)

@kring kring changed the title Use terriajs-cesium 1.15.5. Use terriajs-cesium 1.15.6. Jan 14, 2016
@kring
Copy link
Member Author

kring commented Jan 14, 2016

Here are the differences between 1.15.4 and 1.15.5:
TerriaJS/cesium@terriajs-1.15.4...terriajs-1.15.5

1.15.6 upgraded knockout, but I'm going to revert that because there seems to be an incompatibility between the new version of knockout and our markdown binding.
TerriaJS/cesium@terriajs-1.15.5...terriajs-1.15.6

1.15.6 includes a knockout upgrade that breaks our custom markdown binding.
@kring kring changed the title Use terriajs-cesium 1.15.6. Use terriajs-cesium 1.15.5. Jan 14, 2016
@kring
Copy link
Member Author

kring commented Jan 14, 2016

Done, back to 1.15.5.

RacingTadpole added a commit that referenced this pull request Jan 14, 2016
@RacingTadpole RacingTadpole merged commit 08ad614 into master Jan 14, 2016
@RacingTadpole RacingTadpole deleted the cesium-version branch January 14, 2016 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants