Add icon-image in variable style props #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have the python skills to test that but this is what it should do :
Currently, when the admin sends a layer config (to
api/geolayer/<id>
) with this (only keps the minimal stuff for the example) :the map_style object (send back to the admin in
main_style.map_style
and the one sent to the front) returned is this :When we should have the icon_image style generated like this :
If I understood everything, the icon-image prop is not added to map_style because
field_2_variation_type
returns nothing, so no condition of the ifs is trueTerraVisu/project/terra_layer/style/__init__.py
Line 99 in 260414a
When we want it to go there ->
TerraVisu/project/terra_layer/style/__init__.py
Line 240 in 260414a
Hopefully I didn't miss anything and this should work (not sure about legend gen tho but that's less important)