Add a ScrollBar to the skilllist

[Ewwweee]

feat(EventualSkills) : add a scrollbar to the list of skills in the menu

The scrollbar appears only if the height of the skills exceed the height of the window

It was made to resolve the issue #1 .

[jdrueckert]

@Ewwweee it seems like someone committed to your fork. Is "Ihebsmai" someone you're familiar with?
In any case the file they added needs to be removed again before we can consider merging this.

[Ewwweee]

Hello, I modified my pull request (my friend commit a change in the wrong repo). Do I need to open a new pull request ?

[jdrueckert]

Hi @Ewwweee,
I just tested your PR in-game and that's what the result looks like:

Most problematic here is that when I reduce my window size, I cannot even see the skill buttons anymore:

IIRC what you shared on Discord looked different (and way better) - not sure what happened/changed? 🤔
Anyway, in this state I don't think we can merge this so please revisit your code changes.

[Ewwweee]

Hello ! I fixed the pull request so normally it should work this time (never 2 without 3) ! . I added some skills to test the scrollbar in EventualSkills\prefab. It should look like this image if I correctly did my pull request.

[jdrueckert]

Nice! Now it works perfectly fine 👍
Please remove the dummy skills you added for testing again and then we can get this merged 😃

[Ewwweee]

Hello, thanks for your feedback. I removed the dummy skills so normally it should be ok.

[jdrueckert]

Sorry for the delay, between being sick and the holidays, time just flew by 🙈

I just gave this another test and noticed the following when changing my window size:

As per your changes the skill learning screen has fix dimensions (height and width), causing it to not reduce its height (or width) if the window is smaller.
However, this issue is independent of the screen size being oriented at the number of skills which was resolved using the scrollbar, so I'd argue we can track this in a follow-up issue.

I still need to request two changes before merging, though:

1. please adjust your PR title, as per our contribution guidelines, we try to follow conventional commits
   (please note that this is not necessary for every commit of your PR as we squash-merge it, because that results in a single commit on the module's develop branch based on your PR's title)
2. please remove the logback-test.xml file, we don't need that checked-in to avoid the module behaving differently than the others. if we want to change the current default, this should be done generally for all modules.