refactor: Adjust for Behaviors#89 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few components and systems have changed due to the switch from Pathfinding to FlexiblePathfinding. This PR adjusts the breaking pieces of code to the best of my knowledge. Typical changes for this migration are: - `MinionMoveComponent#target` is now a `Vector3i` and no longer a `Vector3f` (fixed by rounding) - `MinionMoveComponent#type` was removed (no longer required, just remove references)
Respective action has been removed in Terasology/Behaviors#89
jdrueckert
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust for Terasology/Behaviors#89
A few components and systems have changed due to the switch from Pathfinding to FlexiblePathfinding.
This PR adjusts the breaking pieces of code to the best of my knowledge. Typical changes for this migration are:
MinionMoveComponent#targetis now aVector3iand no longer aVector3f(fixed by rounding)MinionMoveComponent#typewas removed (no longer required, just remove references)