Add testing for partitioned BZ2 tables in Hive #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,15 +206,75 @@ public void testCreatePartitionedTableAs(StorageFormat storageFormat) | |||
| query(createTableAsSelect); | |||
|
|
|||
| // SELECT FROM TABLE | |||
| assertSelect("select sum(tax), sum(discount), sum(length(returnflag)) from %s", tableName); | |||
| assertSelect("select sum(tax), sum(discount), sum(length(returnflag)) from %s", tableName, "tpch." + TPCH_SCHEMA + ".lineitem"); | |||
There was a problem hiding this comment.
Can we extract catalog name to a constant?
There was a problem hiding this comment.
I can extract this whole bit to a constant
cawallin
force-pushed
the
bzip-testing
branch
from
1467b22
to
2ba0f86
Compare
In the past, partitioned BZ2 tables in Hive failed. The error now is not reproducable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, partitioned BZ2 tables in Hive failed. The error now is not reproducable.