Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/horizontal stepper #95

Merged
merged 30 commits into from
Oct 11, 2016
Merged

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Oct 11, 2016

Description

Redesigned stepper to allow changing between horizontal/vertical mode without too much complexity.
#29

What's included?

  • Redesigned internally to be make it easier for it to implement layout changes using material2 Portals (following how tabs are implemented to some extent)
  • Added td-step-body and td-step-header to create the step internally.
  • Added mode which takes [StepMode.Horizontal | StepMode.Vertical] or [horizontal | vertical] as input to change the layout of td-steps
  • Added validation to not allow a td-steps component without any td-step children.
  • Added validation to not allow a td-step without a parent td-steps
  • Updated scss to follow specs more to the line.
  • Added ripple effect with md-ripple.
  • Updated layout docs with stepper breaking changes.
  • Updated docs.
  • Updated demo + added responsive demo leveraging our MediaService.

Breaking Change

  • Removed multiple attribute from td-steps since it defeats the purpose of a stepper.
  • td-step-summary and td-step-actions are now directives used with a template (needed for Portal usage)

Before:

<td-step-summary>
  // summary here
</td-step-summary>

<td-step-actions>
  // actions here
</td-step-actions>

After:

<template td-step-summary>
  // summary here
</template >

<template td-step-actions>
  // actions here
</template >
  • td-step content is defined differently now:

Before:

<td-step>
  // content here
</td-step>

After:

<td-step>
  <template td-step-content>
    // content here
  </template >
</td-step>

Test Steps

Screenshots or link to CodePen/Plunker/JSfiddle

stepper-responsive-draft

Copy link
Contributor

@mrjasonweaver mrjasonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @emoralesb05 💥
One thing I noticed in testing the UX: the steps text gets cropped in horizontal mode on small screens.

stepper-small-screen

@mrjasonweaver
Copy link
Contributor

@emoralesb05 Reviewed too soon before realizing there was a responsive change toggle 😄. UX LGTM!

@kyleledbetter
Copy link
Contributor

kyleledbetter commented Oct 11, 2016

Updates

  • blue complete check color like material spec
  • use material2 scss theme
  • text on button toggles
  • bigger warning icon for better fit
  • docs: vertical by default
  • docs: updated text
  • docs: step 1 active for better docs experience

image

@kyleledbetter kyleledbetter merged commit 023d3f3 into develop Oct 11, 2016
@emoralesb05 emoralesb05 deleted the feature/horizontal-stepper branch October 11, 2016 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants