-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/horizontal stepper #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, @emoralesb05 💥
One thing I noticed in testing the UX: the steps text gets cropped in horizontal mode on small screens.
@emoralesb05 Reviewed too soon before realizing there was a responsive change toggle 😄. UX LGTM! |
- increase warn icon size - update horizontal line position
- remove focus/active outline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redesigned stepper to allow changing between horizontal/vertical mode without too much complexity.
#29
What's included?
Portal
s (following how tabs are implemented to some extent)td-step-body
andtd-step-header
to create the step internally.mode
which takes [StepMode.Horizontal
|StepMode.Vertical
] or [horizontal
|vertical
] as input to change the layout oftd-steps
td-steps
component without anytd-step
children.td-step
without a parenttd-steps
md-ripple
.MediaService
.Breaking Change
multiple
attribute fromtd-steps
since it defeats the purpose of a stepper.td-step-summary
andtd-step-actions
are now directives used with a template (needed forPortal
usage)Before:
After:
td-step
content is defined differently now:Before:
After:
Test Steps
ng serve
Screenshots or link to CodePen/Plunker/JSfiddle