Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual-scroll): fix issue with virtual scroll not respecting the parent's width #943

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

emoralesb05
Copy link
Contributor

When using virtual scroll in a narrow area, the elements inside it had a bigger width than expected.

This is fixed by setting the virtual scroll width to 100%.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Release Candidate 0 milestone Oct 22, 2017
@emoralesb05 emoralesb05 merged commit 8849b00 into develop Oct 22, 2017
@emoralesb05 emoralesb05 deleted the feature/fix-virtual-scroll-width branch October 22, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant