Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): show which column was deselected when using single selection mode #896

Merged
merged 1 commit into from
Oct 2, 2017
Merged

fix(data-table): show which column was deselected when using single selection mode #896

merged 1 commit into from
Oct 2, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

What's included?

  • Return unselected row when using single row selection mode in data-table

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

closes #881

@emoralesb05 emoralesb05 added the bug label Oct 1, 2017
@emoralesb05 emoralesb05 mentioned this pull request Oct 1, 2017
Closed
@emoralesb05 emoralesb05 added this to the Beta 8 milestone Oct 2, 2017
jeremysmartt
jeremysmartt approved these changes Oct 2, 2017
View reviewed changes
Copy link
Collaborator

@jeremysmartt jeremysmartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using same Plunker example in bug report, LGTM

@emoralesb05 emoralesb05 merged commit 013df52 into develop Oct 2, 2017
@emoralesb05 emoralesb05 deleted the feature/dt-unselect-row branch October 2, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremysmartt jeremysmartt jeremysmartt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Beta 8
Development

Successfully merging this pull request may close these issues.

Row is empty on row deselect without multiselect
2 participants
@emoralesb05 @jeremysmartt