-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): upgrade to [email protected] #890
Conversation
@jerryorta-dev I think those may be existing issues unrelated to this PR. The existing docs site has the text-wrapping problem on the notifications page. |
This was probably introduced last release since table rows now have height |
When could we roughly expect this to be in? |
@jerryorta-dev yeah, this was introduced with the data table changes.. this will probably need to be reworked and show a list instead of a table since the description is to big for a table.. (feature for td-pretty-markdown) |
@jbojcic1 hopefully in the next few days, this requires lots of testing to be sure we dont break anything |
Created issues for the findings, merging this since most of them are unrelated to the upgrade. |
Description
Following the breaking changes from https://github.com/angular/material2/releases/tag/2.0.0-beta.11, this will give covalent the beta.11 support (provided the mat- prefix is used)
Test Steps
yarn install
ng serve
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to CodePen/Plunker/JSfiddle