Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): upgrade to [email protected] #890

Merged
merged 38 commits into from
Oct 3, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Following the breaking changes from https://github.com/angular/material2/releases/tag/2.0.0-beta.11, this will give covalent the beta.11 support (provided the mat- prefix is used)

Test Steps

  • yarn install
  • ng serve
  • See all still working

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

emoralesb05 added 23 commits September 28, 2017 15:15
@aciccarello
Copy link
Contributor

@jerryorta-dev I think those may be existing issues unrelated to this PR. The existing docs site has the text-wrapping problem on the notifications page.
image

@kyleledbetter
Copy link
Contributor

This was probably introduced last release since table rows now have height

@jbojcic1
Copy link

jbojcic1 commented Oct 2, 2017

When could we roughly expect this to be in?

@emoralesb05 emoralesb05 added this to the Beta 8 milestone Oct 2, 2017
@emoralesb05
Copy link
Contributor Author

@jerryorta-dev yeah, this was introduced with the data table changes.. this will probably need to be reworked and show a list instead of a table since the description is to big for a table.. (feature for td-pretty-markdown)

@emoralesb05
Copy link
Contributor Author

@jbojcic1 hopefully in the next few days, this requires lots of testing to be sure we dont break anything

@jeremysmartt
Copy link
Collaborator

Text in the API Summary on Notifications looks strange:

screen shot 2017-10-02 at 1 16 53 pm

@jeremysmartt
Copy link
Collaborator

When toggling to the Code Tab and then back to Demo tab the Expansion Panels no longer work

expansion bug

@jeremysmartt
Copy link
Collaborator

Adding a file to the File Input clobbers the text on the input box:

screen shot 2017-10-02 at 1 30 00 pm

@jeremysmartt
Copy link
Collaborator

Typo: "Reponsiveness"

screen shot 2017-10-02 at 2 06 32 pm

@jeremysmartt
Copy link
Collaborator

Selecting a chip doesn't work in IE11:

screen shot 2017-10-02 at 2 50 55 pm

@jeremysmartt
Copy link
Collaborator

Chips Events demo acts weird in IE11:

chips event demo

@jeremysmartt
Copy link
Collaborator

Description Resize doesn't work in IE11:

description resize

@jeremysmartt
Copy link
Collaborator

Using Selection on Rows in Table creates strange concatenated Title in Message area:

selection title

@jeremysmartt
Copy link
Collaborator

Tooltips on column headers in IE11 don't work:

tooltips

@jeremysmartt
Copy link
Collaborator

Clear button on Search doesn't work in IE11:

clear

@jeremysmartt
Copy link
Collaborator

Extra Padding at end of Virtual Scroll in IE11:

screen shot 2017-10-02 at 3 34 44 pm

@jeremysmartt
Copy link
Collaborator

Looks like some kind of change detection issue with the Collapse Animation in IE11:

collapse animation

@emoralesb05
Copy link
Contributor Author

Created issues for the findings, merging this since most of them are unrelated to the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants