Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(http): adding complete callback #88

Merged
merged 1 commit into from
Sep 28, 2016
Merged

bugfix(http): adding complete callback #88

merged 1 commit into from
Sep 28, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Sep 20, 2016 •
edited by kyleledbetter
Loading

Description

Added complete() hook as part of the HttpInterceptorService response Observable since it was not being fired when a request is successful.
#87

What's included?

  • Added complete() subscriber hook when request is successful.
  • Added initial draft of code health code for HttpInterceptorService. (karma unit test)

Test Steps

  • npm run test
  • See unit test working with complete method being executed in observable or then method in promise cases.
  • 💥

@emoralesb05 emoralesb05 added this to the Alpha 0.8 milestone Sep 20, 2016
@kyleledbetter kyleledbetter merged commit bd6d500 into develop Sep 28, 2016
@emoralesb05 emoralesb05 deleted the feature/http-complete branch September 28, 2016 22:05
@emoralesb05 emoralesb05 mentioned this pull request Sep 29, 2016
Closed
@emoralesb05 emoralesb05 mentioned this pull request Oct 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleledbetter kyleledbetter kyleledbetter approved these changes

Assignees
No one assigned
Labels
bug code health
Projects
None yet
Milestone
Alpha 0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @kyleledbetter