Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular-cli latest deployed with rc.7 #86

Merged
merged 22 commits into from
Sep 30, 2016
Merged

Conversation

richavyas
Copy link
Collaborator

@richavyas richavyas commented Sep 19, 2016

Description

Updated current build to run app with angular-cli@latest, 1.0.0-beta.15 and webpack, 2.1.0-beta.22

What's included?

  • angular-cli will use latest webpack Beta 22 now.
  • no use of moduleId anymore

Test Steps

  • npm uninstall -g angular-cli
  • npm cache clean
  • rm -rf node_modules dist tmp
  • npm install -g angular-cli@latest
  • ng build
  • ng serve

Issues with current buid

Screenshots or link to CodePen/Plunker/JSfiddle

screen shot 2016-09-19 at 7 15 02 pm

@richavyas
Copy link
Collaborator Author

  • webpack build with [email protected]
  • updated to use angular 2.0.0 & router 3.0
  • hljs needs to be loaded correctly

webpack-15

@emoralesb05
Copy link
Contributor

emoralesb05 commented Sep 24, 2016

Still checking how to import highlight.js correctly.. using require works but trying to see if there is a different way,

@emoralesb05
Copy link
Contributor

  • Had to use require for highlight.js since they dont have ES6/typescript support and avoided linting that line for that file only (so we dont use require anywhere else).

@mrjasonweaver
Copy link
Contributor

Getting these warnings when running ng test

29 09 2016 14:23:33.402:WARN [karma]: No captured browser, open http://localhost:9876/

WARNING in ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
45:15 Critical dependency: the request of a dependency is an expression

WARNING in ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
57:15 Critical dependency: the request of a dependency is an expression

Everything else looks good for running tests.

@mrjasonweaver
Copy link
Contributor

I'm getting an error in terminal when running ng generate component my-new-component. Component scaffolding seems to have been created properly. 😄

installing component
  create src/app/my-new-component/my-new-component.component.scss
  create src/app/my-new-component/my-new-component.component.html
  create src/app/my-new-component/my-new-component.component.spec.ts
  create src/app/my-new-component/my-new-component.component.ts
Cannot read property 'read' of undefined
TypeError: Cannot read property 'read' of undefined
    at InsertChange.apply (/Users/jw186078/Projects/covalent/node_modules/@angular-cli/ast-tools/src/change.js:96:20)
    at /Users/jw186078/Projects/covalent/node_modules/@angular-cli/ast-tools/src/change.js:71:61
    at tryCatch (/Users/jw186078/Projects/covalent/node_modules/es6-promise/dist/lib/es6-promise/-internal.js:195:12)
    at invokeCallback (/Users/jw186078/Projects/covalent/node_modules/es6-promise/dist/lib/es6-promise/-internal.js:210:13)
    at /Users/jw186078/Projects/covalent/node_modules/es6-promise/dist/lib/es6-promise/then.js:24:16
    at flush (/Users/jw186078/Projects/covalent/node_modules/es6-promise/dist/lib/es6-promise/asap.js:94:5)
    at nextTickCallbackWith0Args (node.js:420:9)
    at process._tickCallback (node.js:349:13)

@emoralesb05
Copy link
Contributor

@indyplanets that issue is known angular/angular#11580, but since angular-cli doesnt allow custom webpack.config.js atm, we cant fix it until a next angular-cli version.

Copy link
Contributor

@kyleledbetter kyleledbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencyci is having issues, non-related it seems so i'm gonna merge, nice work!

@kyleledbetter kyleledbetter merged commit 0a272b0 into develop Sep 30, 2016
@emoralesb05 emoralesb05 deleted the feature/webpack-rc7 branch September 30, 2016 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants