Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(behaviors): abstract disableRipple inputs and create mixin for reuse #762

Merged
merged 1 commit into from
Jul 13, 2017
Merged

feat(behaviors): abstract disableRipple inputs and create mixin for reuse #762

merged 1 commit into from
Jul 13, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Second mixin for common behaviors.

What's included?

  • ICanDisableRipple interface
  • mixinDisableRipple mixin
  • use of both in stepper and expansion panel

Test Steps

  • ng serve
  • See disableRipple still working in stepper and expansion panel

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Next Release milestone Jul 13, 2017
@emoralesb05 emoralesb05 merged commit df4fbf1 into develop Jul 13, 2017
@emoralesb05 emoralesb05 deleted the feature/disable-ripple-mixin branch July 13, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilsiepotamus ilsiepotamus ilsiepotamus approved these changes

@jerryorta-dev jerryorta-dev jerryorta-dev approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
Beta.7
Development

Successfully merging this pull request may close these issues.
3 participants
@emoralesb05 @jerryorta-dev @ilsiepotamus