Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): add toggle/open/close directives for layouts with sidenav. #745

Merged
merged 7 commits into from
Jul 7, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Jul 6, 2017

so we can open/close/toggle any sidenav from any child component, we need special directives that access their parent layouts.

with this we can affect the behavior of it, and it also includes [hideWhenOpened] input and a default input to disable/enable the action leveraging the media service

What's included?

  • tdLayoutToggle / tdLayoutOpen and tdLayoutClose directives for parent td-layout

  • tdLayoutNavListToggle / tdLayoutNavListOpen and tdLayoutNavListClose directives for parenttd-layout-nav-list

  • tdLayoutManageListToggle / tdLayoutManageListClose and tdLayoutManageListOpen directives for parent td-layout-manage-list

  • feat(docs): better demos and examples for layouts and directive usages.

Test Steps

  • ng serve
  • See all docs working fine and new examples in layouts
  • Try using any directive under a layout.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

so we can open/close/toggle any sidenav from any child component, we need special directives that access their parent layouts.

with this we can affect the behavior of it, and it also includes [hideWhenOpened] input and a default input to disable/enable the action leveraging the media service
@emoralesb05 emoralesb05 added this to the Next Release milestone Jul 6, 2017
@emoralesb05 emoralesb05 merged commit 346a4bf into develop Jul 7, 2017
@emoralesb05 emoralesb05 deleted the feature/layout-directives branch July 7, 2017 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant