Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(disabled): create a disabled mixin to reuse common disabled behavior #736

Merged
merged 6 commits into from
Jul 6, 2017
Merged

refactor(disabled): create a disabled mixin to reuse common disabled behavior #736

merged 6 commits into from
Jul 6, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Jul 4, 2017 •
edited
Loading

Description

this is the first of many since we need to refactor all common behaviors to centralize them and make them more reusable.

potential mixins could be color, disableRipple, multiple, control value accessor, etc etc

Also:

DEPRECATE feat(chips): rename readOnly to disabled and reuse disabled mixin

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05
refactor(disabled): create a disabled mixin to reuse common disabled …
df631f4 
…behavior

this is the first of many since we need to refactor all common behaviors to centrilize them and make them more reusable.

potential mixins could be color, disableRipple, multiple, etc etc)
@emoralesb05
chore(): polish disabled mixin a bit more
0748e8c 
make it so its easier to check for boolean changes on its input
@emoralesb05
*DEPRECATE* feat(chips): rename readOnly to disabled and reuse disabl…
cafd1d8 
…ed mixin
@emoralesb05 emoralesb05 added this to the Next Release milestone Jul 4, 2017
@emoralesb05 emoralesb05 changed the title ref(disabled): create a disabled mixin to reuse common disabled behavior *DEPRECATE* ref(disabled): create a disabled mixin to reuse common disabled behavior Jul 5, 2017
@emoralesb05 emoralesb05 changed the title *DEPRECATE* ref(disabled): create a disabled mixin to reuse common disabled behavior ref(disabled): create a disabled mixin to reuse common disabled behavior Jul 5, 2017
@emoralesb05 emoralesb05 changed the title ref(disabled): create a disabled mixin to reuse common disabled behavior refactor(disabled): create a disabled mixin to reuse common disabled behavior Jul 5, 2017
richavyas
richavyas reviewed Jul 6, 2017
View reviewed changes
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM

@emoralesb05 emoralesb05 merged commit e07e8e8 into develop Jul 6, 2017
@emoralesb05 emoralesb05 deleted the feature/disabled-mixin branch July 6, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richavyas richavyas richavyas left review comments

Assignees
No one assigned
Labels
deprecate enhancement ux lgtm
Projects
None yet
Milestone
Beta.6
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @richavyas