Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/markdown docs rc6 #70

Merged
merged 6 commits into from
Sep 13, 2016
Merged

Feature/markdown docs rc6 #70

merged 6 commits into from
Sep 13, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Sep 12, 2016 •
edited by kyleledbetter
Loading

Description

Updated docs and setup for markdown module to use ngModule.
#65

What's included?

  • Updated markdown docs setup.
  • Updated README.md
  • Added own file for markdown.module and forRoot() method.

Test Steps

@emoralesb05 emoralesb05 changed the title Feature/markdown docs Feature/markdown docs rc6 Sep 12, 2016
@emoralesb05 emoralesb05 added this to the Alpha 0.7 milestone Sep 12, 2016
@kyleledbetter kyleledbetter merged commit b81ec38 into develop Sep 13, 2016
@emoralesb05 emoralesb05 deleted the feature/markdown-docs branch September 13, 2016 16:08
emoralesb05 pushed a commit that referenced this pull request Jul 23, 2019
feat(utils): add loadMonaco utility function (#70)
543baf6 
* feat(utils): add loadMonaco utility function

plus make sure _editor is initially undefined and add checks across code to validate that it has to have a value before doing something to it

* feat(): use const instead of let and switch load/wait for monaco calls
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
feat(utils): add loadMonaco utility function (Teradata#70)
a707984 
* feat(utils): add loadMonaco utility function

plus make sure _editor is initially undefined and add checks across code to validate that it has to have a value before doing something to it

* feat(): use const instead of let and switch load/wait for monaco calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ux lgtm
Projects
None yet
Milestone
Alpha 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @kyleledbetter