Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/chips docs #68

Merged
merged 3 commits into from
Sep 13, 2016
Merged

Feature/chips docs #68

merged 3 commits into from
Sep 13, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Sep 12, 2016 •
edited by kyleledbetter
Loading

Description

Updated chips module with ngModule usage.
#65

What's included?

  • Updated docs and examples with ngModule usage.
  • Added own file for chips.module.
  • Added forRoot() method to module.
  • Updated README.md with setup.

Test Steps

@emoralesb05 emoralesb05 added this to the Alpha 0.7 milestone Sep 12, 2016
@kyleledbetter kyleledbetter merged commit 7fbbcef into develop Sep 13, 2016
@emoralesb05 emoralesb05 deleted the feature/chips-docs branch September 13, 2016 16:08
emoralesb05 pushed a commit that referenced this pull request Jul 23, 2019
fix(): make sure editor is instantiated before disposing (#68)
3be0008 
Sometimes when editor is destroyed to quick, we get an  undefined error
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
fix(): make sure editor is instantiated before disposing (Teradata#68)
925e5a5 
Sometimes when editor is destroyed to quick, we get an  undefined error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ux lgtm
Projects
None yet
Milestone
Alpha 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @kyleledbetter