Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): leverage td-chip for all cases introducing td-chip-avatar #672

Merged
merged 5 commits into from
Jun 8, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

now we can use normal chip strings, template chips and contact chips by mixin and matching our templates and directives

we renamed td-basic-chip to td-chip since it will serve a generic purpose depending on its content.

What's included?

  • Styling for [td-chip-avatar]
  • Updated demos

Usage

<td-chips>
  <ng-template td-chip let-chip="chip">
    <div class="tc-grey-100 bgc-teal-700" td-chip-avatar>{{chip.substring(0, 1).toUpperCase()}}</div>
  </ng-template>
</td-chips>

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

image

…r directive

now we can use normal chip strings, template chips and contact chips by mixin and matching our templates and directives
@emoralesb05 emoralesb05 added this to the Beta.5 milestone Jun 8, 2017
@emoralesb05 emoralesb05 merged commit fe9dacc into develop Jun 8, 2017
@emoralesb05 emoralesb05 deleted the feature/contact-chips branch June 8, 2017 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant