Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expansion-panel): introducing expansion-panel-group to only give margin to expansion panels when grouped #666

Merged
merged 3 commits into from
Jun 7, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

this will give spec margin to grouped expansion panels following the spec, but its optional so we can use stand alone expansion panels without margin too for other use cases.

What's included?

  • new component TdExpansionPanelGroupComponent so we can group expansion panels and add margin following material spec

Usage

<td-expansion-panel-group>
  <td-expansion-panel label="Label goes here">
    <div class="md-padding">
      <h3 class="md-subhead">md-padding class</h3>
    </div>
  </td-expansion-panel>
  <td-expansion-panel label="Another label goes here">
    <div class="md-padding">
      <h3 class="md-subhead">md-padding class</h3>
    </div>
  </td-expansion-panel>
  <td-expansion-panel label="Yet another label goes here">
    <div class="md-padding">
      <h3 class="md-subhead">md-padding class</h3>
    </div>
  </td-expansion-panel>
</td-expansion-panel-group>

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

this will give spec marging to grouped expansion panels following the spec
@emoralesb05 emoralesb05 added this to the Beta.5 milestone Jun 7, 2017
@emoralesb05 emoralesb05 changed the title feat(expansion): introducing expansion-panel-group feat(expansion-panel): introducing expansion-panel-group to only give margin to expansion panels when grouped Jun 7, 2017
@emoralesb05 emoralesb05 merged commit 9ae0ba5 into develop Jun 7, 2017
@emoralesb05 emoralesb05 deleted the feature/expansion-panel-group branch June 7, 2017 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants