-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rtl-demo): fix rtl/lrt demo in docs #663
Conversation
there were issues when navigation between views or when using the td-layout.. state was lost and sidenavs were not working as intended.
Refreshing the browser while in ERROR TypeError: Cannot read property 'toArray' of undefined
at MdSidenavContainer._validateDrawers (material.es5.js:11389)
at material.es5.js:11287
at SafeSubscriber.schedulerFn [as _next] (core.es5.js:3842)
at SafeSubscriber.__tryOrUnsub (Subscriber.js:238)
at SafeSubscriber.next (Subscriber.js:185)
at Subscriber._next (Subscriber.js:125)
at Subscriber.next (Subscriber.js:89)
at EventEmitter.Subject.next (Subject.js:55)
at EventEmitter.emit (core.es5.js:3816)
at Dir.set [as dir] (material.es5.js:341) |
This scenario takes a very long time ( 3s ) to transition views - I thought it was a dead link at first:
|
Edit: my bad, went back to the wrong command line instance to test... all good on this Unit tests pass, but there is a lot of console log output. ERROR: 'ERROR', TypeError{ngDebugContext: DebugContext_ ...
|
The 3 seconds thing happens with lazy module loading + JIT, it doesnt really happen in production (AoT). That being said, found a weird behavior where since |
… not needed this still will happen when trying to access any other chunk though.. for some reason they load anything before them.
Fixed issue with |
I realized the lazyload issue once I saw the routes. The site https://teradata.github.io/covalent is production, correct? It's still a little slow on route changes there too. I have a selective-preload-strategy I can implement if you want to give it a go. It lazy loads immediately, after the first module loads. |
Since lazyload is not a part of this issue, this is approved. |
We can discuss that approach offline. 👍 |
there were issues when navigation between views or when using the td-layout.. state was lost and sidenavs were not working as intended.
Test Steps
ng serve
rtl
modeGeneral Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to CodePen/Plunker/JSfiddle