-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chips): chip templates + object list support + async loading support. (closes #252) (closes #359) (closes #601) #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utocomplete and chips this will be the base to support contact chips. First we need to make sure it works fine with objects and strings, and add good a11y around this.
…g children in templates)
…omplete in a11y mode
…d add debounce input it makes more sense to have the filtering done outside of chips and provide examples on how to achieve it since this way chips are agnostic of local vs server side filtering + string vs object filtering
…or something on long filters
This was referenced May 26, 2017
7 tasks
beta.6 has some nuances around autocomplete so its needed to have more control
This was referenced May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses:
#359
#601
#252
Part of
OnPush
epic: #325What's included?
fix(chips): keep focused state as long as you keep clicking inside the chips context.
fix(chips): make underline animate the same way as material
feat(chips): ability to use object lists and set templates for both
autocomplete
andchips
this will be the base to support contact chips.
Usage
autocomplete
filtering and add[debounce]
input and(inputChange)
output to implement filtering locally or server side.it makes more sense to have the filtering done outside of chips and we also provide examples on how to achieve it since this way chips are agnostic of local vs server side filtering + string vs object filtering
Usage
OnPush
change detectionTest Steps
ng serve
a11y
,click selections
,filtering
, etc etc)General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.