feat(data-table): indeterminate state in 'selectAll' checkbox (closes #571) #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when atleast one row is selected and not every row is selected, the checkbox for select/deselect all should be in indeterminate state.
jeremysmartt
reviewed
May 8, 2017
| @@ -303,6 +312,7 @@ export class TdDataTableComponent implements ControlValueAccessor, AfterContentI | |||
| } else { | |||
| this.clearModel(); | |||
| } | |||
| this._calculateCheckboxState(); | |||
There was a problem hiding this comment.
why not just set the this._allSelected here? You already looped through everything so you shouldn't need to do it again as you already know what the state should be.
There was a problem hiding this comment.
true! ill change that real quick
jeremysmartt
reviewed
May 8, 2017
| })(); | ||
| }); | ||
|
|
||
| it('should select one and be in indeterminate state, select all and then unselect all', |
|
UX is lovely, i'm ready to merge when i get signoff on the code |
kyleledbetter
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when at least one row is selected and not every row is selected, the checkbox for select/deselect all should be in indeterminate state.
#571
What's included?
Test Steps
ng servedata-tabledemomultiple/selectabledemoGeneral Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to CodePen/Plunker/JSfiddle