feat: Data Table: Searchable and Unsearchable columns #548
Conversation
Added notsearchable property on columns to keep certain columns from being searched on in the filterData method. Also added unit tests for table and updated documentation. Closes #513
jeremysmartt
changed the title
|
love the PR, could we name the input something more simple like |
|
I feel that this is more a design pattern than an enhancement.. not sure about this yet. Although i do see the need for that extra parameter in |
|
Right at first I thought maybe a design pattern, but then actually I don't think it is. I think the ability to pass in the columns and get hits based on properties will continue to be needed. For example, probably want to do the same thing when a column is hidden: |
|
The use case is legit, just debating if it should be part of the interface or applied in a different way since this seems more of an sorting implementation thing. In both cases, there is stuff to be done in |
|
@kyleledbetter I updated the name of the input to be filter="false" and true is the default. |
|
since we have a new batch of filtering/hiding/showing features coming, thinking we can do a new demo since that current demo is getting a little convoluted |
|
maybe not another demo, but maybe update the current complex datatable demo to use slide toggles for options instead of md-buttons, i'll take a stab |
|
Another framework provides the ability to define both global and individual filters. Wondering if this PR should really be addressed by being able to filter on a per column basis. I, as a user, would find it confusing that I saw data in a column of the table that wasn't visible after input of some global filter value that matched the value that saw in that column. Alternatively, I'd want some visual indicator that the particular column isn't participating in the filter? |
…om the search rather than the full columns config object. This will allow the columns by which you are searching on to be more easily changed on the fly
…wards compatability test
| @@ -13,14 +13,16 @@ export class TdDataTableService { | |||
| * | |||
| * Searches [data] parameter for [searchTerm] matches and returns a new array with them. | |||
| */ | |||
| filterData(data: any[], searchTerm: string, ignoreCase: boolean = false): any[] { | |||
| filterData(data: any[], searchTerm: string, ignoreCase: boolean = false, nonSearchAbleColumns?: string[]): any[] { | |||
There was a problem hiding this comment.
Should we just call this excludedColumns?
| import { NgModule, DebugElement } from '@angular/core'; | ||
| import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; | ||
|
|
||
| describe('Component: TdPagingBarComponent', () => { |
There was a problem hiding this comment.
should be 'Component: DataTable'.
| @@ -328,7 +328,7 @@ <h4 class="md-subhead">Paging Bar / Search Box / Sortable components</h4> | |||
|
|
|||
| filter(): void { | |||
| let newData: any[] = this.data; | |||
| newData = this._dataTableService.filterData(newData, this.searchTerm, true); | |||
| newData = this._dataTableService.filterData(newData, this.searchTerm, true, this.columns); | |||
There was a problem hiding this comment.
Demo needs to be updated with latest API changes.
…n unit test file, updating demo with latest API changes
Description
Added notsearchable property on columns to keep certain columns from being searched on in the filterData method. Also added unit tests for table and updated documentation.
Closes #513
What's included?
Test Steps
General Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to CodePen/Plunker/JSfiddle